Re: [PATCH V2] CS89x0 : Use ioread16/iowrite16 on all platforms

On Wed, 2012-05-16 at 00:37 +0200, Francois Romieu wrote:

Jaccon Bastiaansen [off-list ref] :
[...]

quoted

diff --git a/drivers/net/ethernet/cirrus/cs89x0.c b/drivers/net/ethernet/cirrus/cs89x0.c
index b9406cb..8081ad5 100644
--- a/drivers/net/ethernet/cirrus/cs89x0.c
+++ b/drivers/net/ethernet/cirrus/cs89x0.c

[...]

quoted

-static int cs89x0_probe1(struct net_device *dev, unsigned long ioaddr, int modular);
+static int cs89x0_probe1(struct net_device *dev,
+			 void __iomem *ioaddr,
+			 int modular);
+static int cs89x0_probe1(struct net_device *dev, void __iomem *ioaddr,
+			 int modular);

s/int/bool/ maybe.

You may skip the name of the parameters.

Better would be to not duplicate the prototype
and better still would be to reorder the code to
avoid the prototype altogether.