Re: [net] stmmac: fix driver Kconfig when built as module

On 5/23/2012 8:01 PM, David Miller wrote:

From: Giuseppe CAVALLARO <redacted>
Date: Wed, 23 May 2012 08:05:42 +0200

quoted

This patches fixes the driver when built as dyn module.
In fact the platform part cannot be built and the probe fails
(thanks to Bob Liu that reported this bug).
The patch also makes the selection of Platform and PCI parts
mutually exclusive.

Reported-by: Bob Liu <redacted>
Signed-off-by: Giuseppe Cavallaro <redacted>
Reviewed-by: Ben Hutchings <redacted>

We have drivers which support both OF (which is implemented as
platform bus) and PCI at the same time.  For example,
drivers/net/ethernet/sun/niu.c

I do not see why stmmac cannot support both at the same time as well.

I absolutely do not want such segregation unless it is absolutely
necessary.  Because it means that no matter what is choosen, a piece
of code is disabled and therefore not getting build and/or runtime
validation.

Ok, I'll review it and resend all the patches asap.

Regards
Peppe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html