Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2012-04-30 21:57:43
Also in:
linuxppc-dev, lkml
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2012-04-30 21:57:43
Also in:
linuxppc-dev, lkml
On Tue, 2012-05-01 at 07:55 +1000, Benjamin Herrenschmidt wrote:
On Mon, 2012-04-30 at 13:41 -0400, David Miller wrote:quoted
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: Mon, 30 Apr 2012 15:26:08 +1000quoted
David, what's the right way to fix that ?There is no doubt that sock_fprog is the correct datastructure to use.Ok, so the right fix is to email anybody who posted code using struct bpf_program to fix their code ? :-)
Actually, the right fix is for anybody using pcap-bpf.h to not use SO_ATTACH_FILTER directly but to use pcap_setfilter() which handles the compatibility. I'll start spamming web sites who tell people to do the wrong thing. Cheers, Ben.