Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

[REGRESSION][PATCH V4 0/3] bpf jit drops the ball on negative memory references · Jan Seiffert <hidden> · 2012-03-30
[REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits · Jan Seiffert <hidden> · 2012-03-30
Re: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits · Eric Dumazet <hidden> · 2012-03-30
RE: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits · David Laight <hidden> · 2012-04-02
Re: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits · Jan Seiffert <hidden> · 2012-04-02
Re: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits · David Miller <davem@davemloft.net> · 2012-04-03
Re: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits · Jan Seiffert <hidden> · 2012-04-03
Re: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits · David Miller <davem@davemloft.net> · 2012-04-03
Re: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits · Jan Seiffert <hidden> · 2012-04-03
[REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Jan Seiffert <hidden> · 2012-03-30
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · David Miller <davem@davemloft.net> · 2012-04-03
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Benjamin Herrenschmidt <benh@kernel.crashing.org> · 2012-04-03
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Benjamin Herrenschmidt <benh@kernel.crashing.org> · 2012-04-30
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Benjamin Herrenschmidt <benh@kernel.crashing.org> · 2012-04-30
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Jan Seiffert <hidden> · 2012-04-30
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Benjamin Herrenschmidt <benh@kernel.crashing.org> · 2012-04-30
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Jan Seiffert <hidden> · 2012-04-30
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Benjamin Herrenschmidt <benh@kernel.crashing.org> · 2012-04-30
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Jan Seiffert <hidden> · 2012-04-30
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Benjamin Herrenschmidt <benh@kernel.crashing.org> · 2012-04-30
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · David Miller <davem@davemloft.net> · 2012-04-30
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Benjamin Herrenschmidt <benh@kernel.crashing.org> · 2012-04-30
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Benjamin Herrenschmidt <benh@kernel.crashing.org> · 2012-04-30
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Jan Seiffert <hidden> · 2012-04-30
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Benjamin Herrenschmidt <benh@kernel.crashing.org> · 2012-05-01
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Jan Seiffert <hidden> · 2012-05-01
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Benjamin Herrenschmidt <benh@kernel.crashing.org> · 2012-05-01
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · David Miller <davem@davemloft.net> · 2012-05-01
[REGRESSION][PATCH V5 3/3] bpf jit: Let the powerpc jit handle negative offsets · Jan Seiffert <hidden> · 2012-04-30
Re: [REGRESSION][PATCH V5 3/3] bpf jit: Let the powerpc jit handle negative offsets · David Miller <davem@davemloft.net> · 2012-04-30
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · Jan Seiffert <hidden> · 2012-04-03
Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets · David Miller <davem@davemloft.net> · 2012-04-03
[REGRESSION][PATCH V4 2/3] bpf jit: Let the x86 jit handle negative offsets · Jan Seiffert <hidden> · 2012-03-30
Re: [REGRESSION][PATCH V4 2/3] bpf jit: Let the x86 jit handle negative offsets · Eric Dumazet <hidden> · 2012-03-30
Re: [REGRESSION][PATCH V4 2/3] bpf jit: Let the x86 jit handle negative offsets · David Miller <davem@davemloft.net> · 2012-04-03
[PATCH V1 1/1] NET: add a bpf jit for Alpha · Jan Seiffert <hidden> · 2012-04-02
Re: [PATCH V1 1/1] NET: add a bpf jit for Alpha · Matt Turner <mattst88@gmail.com> · 2012-04-02
Re: [PATCH V1 1/1] NET: add a bpf jit for Alpha · Jan Seiffert <hidden> · 2012-04-02
Re: [PATCH V1 1/1] NET: add a bpf jit for Alpha · Richard Henderson <hidden> · 2012-04-04
Re: [PATCH V1 1/1] NET: add a bpf jit for Alpha · Jan Seiffert <hidden> · 2012-04-05
[REGRESSION][PATCH v1] bpf jit: Let the arm jit handle negative memory references · Jan Seiffert <hidden> · 2012-04-06
[REGRESSION][PATCH v2] bpf jit: Let the arm jit handle negative memory references · Jan Seiffert <hidden> · 2012-04-06
Re: [REGRESSION][PATCH v1] bpf jit: Let the arm jit handle negative memory references · Mircea Gherzan <hidden> · 2012-04-06
Re: [REGRESSION][PATCH v1] bpf jit: Let the arm jit handle negative memory references · Jan Seiffert <hidden> · 2012-04-06
Re: [REGRESSION][PATCH v1] bpf jit: Let the arm jit handle negative memory references · Eric Dumazet <hidden> · 2012-04-07

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2012-04-30 04:30:15
Also in: linuxppc-dev, lkml

On Mon, 2012-04-30 at 06:27 +0200, Jan Seiffert wrote:

Benjamin Herrenschmidt schrieb:

quoted

On Mon, 2012-04-30 at 12:43 +1000, Benjamin Herrenschmidt wrote:

quoted

Matt's having a look at powerpc

Ok, he hasn't so I'll dig a bit.

No obvious wrongness (but I'm not very familiar with bpf), though I do
have a comment: sk_negative_common() and bpf_slow_path_common() should
be made one and single macro which takes the fallback function as an
argument.

Ok, with the compile fix below it seems to work for me:

(Feel free to fold that into the original patch)

Should i resend the complete patch with the compile fix?

Won't hurt...

BTW. Any idea about that bpf_program vs. sock_fprog issue I mentioned
earlier ?

Cheers,
Ben.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help