Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2012-04-30 02:44:00
Also in:
linuxppc-dev, lkml
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2012-04-30 02:44:00
Also in:
linuxppc-dev, lkml
On Wed, 2012-04-04 at 08:11 +1000, Benjamin Herrenschmidt wrote:
On Tue, 2012-04-03 at 18:03 -0400, David Miller wrote:quoted
quoted
Signed-off-by: Jan Seiffert <redacted> I have only compile tested this, -ENOHARDWARE. Can someone with more powerpc kung-fu review and maybe test this? Esp. powerpc asm is not my strong point. I think i botched the stack frame in the call setup. Help?I'm not applying this until a powerpc person tests it. Also, we have an ARM JIT in the tree which probably needs to be fixed similarly.Matt's having a look at powerpc
Ok, he hasn't so I'll dig a bit. No obvious wrongness (but I'm not very familiar with bpf), though I do have a comment: sk_negative_common() and bpf_slow_path_common() should be made one and single macro which takes the fallback function as an argument. I'll mess around & try to test using Jan test case & will come back with an updated patch. Cheers, Ben.