Re: [net-next 3/3] ixgbe: add syfs interface for to export read only driver information
flat view
From: Rustad, Mark D <hidden>
Date: 2012-04-05 23:52:43
On Apr 5, 2012, at 9:32 AM, Ben Hutchings wrote:
On Thu, 2012-04-05 at 14:19 +0200, Florian Fainelli wrote:quoted
Hi, Le 04/05/12 12:47, Jeff Kirsher a écrit :quoted
From: Don Skidmore<redacted> This patch exports non-thermal (which was done via hwmon in an earlier patch) data to syfs. All of the fields are read only as this interface is to only export driver data. Signed-off-by: Don Skidmore<redacted> Tested-by: Stephen Ko<redacted> Signed-off-by: Jeff Kirsher<redacted> ---I only looked briefly at the exported attributes, but most of them can already be queried using ethtool, can't they?[...] I agree, it looks like most of these are: (1) already exposed through ethtool commands (ETHTOOL_GSET, ETHTOOL_GDRVINFO, ETHTOOL_GLINK and ETHTOOL_GPERMADDR), or (2) already exposed through rtnetlink or the net device in sysfs, or (3) statistics that should be exposed through ETHTOOL_GSTATS I imagine there are some that don't fall into those categories, but I don't see why they should *all* be exposed in a non-standard and/or redundant way.
The redundancy with ethtool doesn't bother me much, because I think sysfs is a more general way to export driver information, and I find it very convenient to get as much as is practical from a single source. I really like doing "grep . * */*" in sysfs and getting as much information as possible about a driver. That said, there does appear to be duplication with some existing sysfs statistics, which should not be needed, and I think the volume of code in the implementation can be reduced as well. -- Mark Rustad, LAN Access Division, Intel Corporation