RE: [net-next 3/3] ixgbe: add syfs interface for to export read only driver information

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Thursday, April 05, 2012 3:50 PM
To: bhutchings@solarflare.com
Cc: florian@openwrt.org; Kirsher, Jeffrey T; Skidmore, Donald C;
netdev@vger.kernel.org; gospo@redhat.com; sassmann@redhat.com
Subject: Re: [net-next 3/3] ixgbe: add syfs interface for to export read
only driver information

From: Ben Hutchings <redacted>
Date: Thu, 5 Apr 2012 17:32:05 +0100

quoted

On Thu, 2012-04-05 at 14:19 +0200, Florian Fainelli wrote:

quoted

Hi,

Le 04/05/12 12:47, Jeff Kirsher a écrit :

quoted

From: Don Skidmore<redacted>

This patch exports non-thermal (which was done via hwmon in an

earlier

quoted

quoted

quoted

patch) data to syfs.  All of the fields are read only as this

interface

quoted

quoted

quoted

is to only export driver data.

Signed-off-by: Don Skidmore<redacted>
Tested-by: Stephen Ko<redacted>
Signed-off-by: Jeff Kirsher<redacted>
---

I only looked briefly at the exported attributes, but most of them

can

quoted

quoted

already be queried using ethtool, can't they?

[...]

I agree, it looks like most of these are:

(1) already exposed through ethtool commands (ETHTOOL_GSET,
ETHTOOL_GDRVINFO, ETHTOOL_GLINK and ETHTOOL_GPERMADDR), or
(2) already exposed through rtnetlink or the net device in sysfs, or
(3) statistics that should be exposed through ETHTOOL_GSTATS

I imagine there are some that don't fall into those categories, but I
don't see why they should *all* be exposed in a non-standard and/or
redundant way.

Agreed.

Thanks for the input.  I'll start on refactoring the patch to exclude all items that are exposed in any other way.

-Don Skidmore [off-list ref]