Re: [net-next 3/3] ixgbe: add syfs interface for to export read only driver information

On Thu, 2012-04-05 at 14:19 +0200, Florian Fainelli wrote:

Hi,

Le 04/05/12 12:47, Jeff Kirsher a écrit :

quoted

From: Don Skidmore<redacted>

This patch exports non-thermal (which was done via hwmon in an earlier
patch) data to syfs.  All of the fields are read only as this interface
is to only export driver data.

Signed-off-by: Don Skidmore<redacted>
Tested-by: Stephen Ko<redacted>
Signed-off-by: Jeff Kirsher<redacted>
---

I only looked briefly at the exported attributes, but most of them can 
already be queried using ethtool, can't they?

[...]

I agree, it looks like most of these are:

(1) already exposed through ethtool commands (ETHTOOL_GSET,
ETHTOOL_GDRVINFO, ETHTOOL_GLINK and ETHTOOL_GPERMADDR), or
(2) already exposed through rtnetlink or the net device in sysfs, or
(3) statistics that should be exposed through ETHTOOL_GSTATS

I imagine there are some that don't fall into those categories, but I
don't see why they should *all* be exposed in a non-standard and/or
redundant way.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.