Re: [PATCH 2/3] netfilter: potential null derefence.

On Fri, Mar 02, 2012 at 10:31:23PM +0100, Bart De Schuymer wrote:

Op 1/03/2012 13:30, Pablo Neira Ayuso schreef:

quoted

On Thu, Mar 01, 2012 at 02:47:14PM +0530, santosh nayak wrote:

quoted

From: Santosh Nayak<redacted>

I am getting following error.
" net/bridge/netfilter/ebtables.c:269 ebt_do_table()
  error: potential null derefence 'cs'"

    i = cs[sp].n;  // If cs == Null then this will cause problem.

Very sorry, I didn't see the out label.

I'll apply this to my nf [1] once David takes my previous request for
pulling.

Hi,

Has this patch been tested? Really, that code in the core firewall
function is there for a reason, wouldn't you think?
The chainstack is only allocated when user-defined chains are used
(see translate_table).
Never blindly trust a tool.

I see, then that cs NULL dereference never happens.

Thanks Bart, I'll drop this patch.