Re: [PATCH 2/3] netfilter: potential null derefence.

Hi Pablo,

Please look at the last line of my patch.
I have added a new label "out"

regards
santosh

On Thu, Mar 1, 2012 at 3:51 PM, Pablo Neira Ayuso [off-list ref] wrote:

On Thu, Mar 01, 2012 at 02:47:14PM +0530, santosh nayak wrote:

quoted

From: Santosh Nayak <redacted>

I am getting following error.
" net/bridge/netfilter/ebtables.c:269 ebt_do_table()
  error: potential null derefence 'cs'"

    i = cs[sp].n;  // If cs == Null then this will cause problem.

Signed-off-by: Santosh Nayak <redacted>
---
 net/bridge/netfilter/ebtables.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index f3fcbd9..9c0f177 100644
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c

@@ -209,8 +209,10 @@ unsigned int ebt_do_table (unsigned int hook, struct sk_buff *skb,

         smp_processor_id());
      if (private->chainstack)
              cs = private->chainstack[smp_processor_id()];
-     else
+     else {
              cs = NULL;
+             goto out;

There is no "out" label in ebt_do_table !!