Thread (7 messages) flat view 7 messages, 3 authors, 2012-03-03

Re: [PATCH 2/3] netfilter: potential null derefence.

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2012-03-01 10:21:41
Also in: bridge, kernel-janitors, lkml, netfilter-devel

On Thu, Mar 01, 2012 at 02:47:14PM +0530, santosh nayak wrote:
quoted hunk ↗ jump to hunk
From: Santosh Nayak <redacted>

I am getting following error.
" net/bridge/netfilter/ebtables.c:269 ebt_do_table()
  error: potential null derefence 'cs'"

    i = cs[sp].n;  // If cs == Null then this will cause problem.

Signed-off-by: Santosh Nayak <redacted>
---
 net/bridge/netfilter/ebtables.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index f3fcbd9..9c0f177 100644
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -209,8 +209,10 @@ unsigned int ebt_do_table (unsigned int hook, struct sk_buff *skb,
 	   smp_processor_id());
 	if (private->chainstack)
 		cs = private->chainstack[smp_processor_id()];
-	else
+	else {
 		cs = NULL;
+		goto out;
There is no "out" label in ebt_do_table !!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help