Re: [PATCH net-next v4] ipv6: Allocate unique metrics for icmp6 packets to prevent tainting dst metrics

From: Nick Jones <redacted>
Date: Tue, 20 Mar 2012 13:48:01 +0800

On Mon, 2012-03-19 at 18:04 -0400, David Miller wrote: 

quoted

Furthermore, callers are only ready to handle NULL vs. non-NULL as
return values from this function.  So this return value you are adding
will result in crashes.

This one I did check.  icmp6_dst_alloc returns error encoded pointers
and all call sites test the return value with IS_ERR, I simply didn't
understand the correct formatting macro, nor check the build properly.
I think you got it mixed up with ip6_dst_alloc

Indeed you're right on this one.  We changed this recently, in fact.