Re: [PATCH net-next v4] ipv6: Allocate unique metrics for icmp6 packets to prevent tainting dst metrics

From: Nick Jones <redacted>
Date: Sun, 18 Mar 2012 01:43:39 +0800

+		return ERR_CAST(-ENOMEM);

Really, please, stop wasting my time.  There is no way your compiler
didn't emit a warning for that garbage.

Furthermore, callers are only ready to handle NULL vs. non-NULL as
return values from this function.  So this return value you are adding
will result in crashes.