Thread (8 messages) flat view 8 messages, 3 authors, 2012-03-20

Re: [PATCH net-next v2] ipv6: Allocate unique metrics for icmp6 packets to prevent tainting dst metrics

From: David Miller <davem@davemloft.net>
Date: 2012-03-17 06:02:52

From: Nick Jones <redacted>
Date: Thu, 15 Mar 2012 23:41:57 +0800
+	u32 *metrics = kzalloc(sizeof(u32) * RTAX_MAX, GFP_ATOMIC);
Please do not declare local variables in the middle of a function's
statements.  Put it at the top of the basic block where it belongs.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help