Thread (20 messages) flat view 20 messages, 5 authors, 2012-02-17

Re: [PATCH 2/2] bluetooth: Convert BT_DBG to pr_debug

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2012-02-13 07:21:39
Also in: linux-bluetooth, lkml

Hi Joe,
quoted
quoted
No need to obfuscate, just use the normal debugging macro.
Add "\n" to uses, align arguments, coalesce formats.
Fix a typo and fix a bad format extended by a line continuation.
what is this patch buying us.
Easier greps of pr_debug.
BT_DBG is just an unnecessary useless wrapper.
quoted
The only useful change would be to move to dev_printk, but we are not
there yet.
Maybe dev_dbg, but there isn't always an
appropriate device * available.
exactly. And that needs to be fixed first. People are working on getting
some old legacy 2.4 leftovers out of this subsystem so we can have first
call struct device everywhere.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help