Re: [PATCH v3 02/16] e100: Support RXFCS feature flag.
From: Ben Greear <hidden>
Date: 2012-02-13 17:19:42
On 02/11/2012 09:07 AM, Eric Dumazet wrote:
Le vendredi 10 février 2012 à 17:04 -0800, greearb@candelatech.com a écrit :quoted
From: Ben Greear<redacted> This allows e100 to be configured to append the Ethernet FCS to the skb. Useful for sniffing networks. Signed-off-by: Ben Greear<redacted> ---Did you try this patch with 8021Q frames ? You must change #define RFD_BUF_LEN (sizeof(struct rfd) + VLAN_ETH_FRAME_LEN) to : #define RFD_BUF_LEN (sizeof(struct rfd) + VLAN_ETH_FRAME_LEN + ETH_FCS_LEN) And also on various spots where VLAN_ETH_FRAME_LEN is used in this driver... nic->blank_rfd.size = cpu_to_le16(VLAN_ETH_FRAME_LEN);
Thanks for the review. I did not try it with VLAN frames. It may be a few days until I can get this done and test it well.... Thanks, Ben -- Ben Greear [off-list ref] Candela Technologies Inc http://www.candelatech.com