Thread (24 messages) flat view 24 messages, 5 authors, 2012-02-13

Re: [PATCH v3 02/16] e100: Support RXFCS feature flag.

From: Eric Dumazet <hidden>
Date: 2012-02-11 17:07:48

Le vendredi 10 février 2012 à 17:04 -0800, greearb@candelatech.com a
écrit :
From: Ben Greear <redacted>

This allows e100 to be configured to append the
Ethernet FCS to the skb.

Useful for sniffing networks.

Signed-off-by: Ben Greear <redacted>
---
Did you try this patch with 8021Q frames ?

You must change 

#define RFD_BUF_LEN (sizeof(struct rfd) + VLAN_ETH_FRAME_LEN)

to :

#define RFD_BUF_LEN (sizeof(struct rfd) + VLAN_ETH_FRAME_LEN + ETH_FCS_LEN)

And also on various spots where VLAN_ETH_FRAME_LEN is used in this
driver...

nic->blank_rfd.size = cpu_to_le16(VLAN_ETH_FRAME_LEN);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help