Re: [patch v1, kernel version 3.2.1] net/ipv4/ip_gre: Ethernet multipoint GRE over IP

Le lundi 16 janvier 2012 à 15:05 +0100, Štefan Gula a écrit :

Dňa 16. januára 2012 14:19, Eric Dumazet [off-list ref] napísal/a:

quoted

Unfortunately you call ipgre_tap_bridge_get() from
ipgre_tap_bridge_get_raddr() but you dont release the refcount on
use_count. Leak in ipgre_tunnel_xmit()

quoted

+__be32 ipgre_tap_bridge_get_raddr(struct ip_tunnel *tunnel,
+     const unsigned char *addr)
+{
+     struct ipgre_tap_bridge_entry *entry;
+     entry = ipgre_tap_bridge_get(tunnel, addr);

       So maybe you want __ipgre_tap_bridge_get(tunnel, addr); here ?

Hmmm.. I am sorry, I am maybe not that expert on C coding, as most of
the codes were copied from linux bridge code. Can you give me a hint
how should I change that?

I dont see in net/bridge the code you copied.

Could you give more information ?