Re: [PATCH] bridge: BH already disabled in br_fdb_cleanup()
From: Stephen Hemminger <hidden>
Date: 2012-01-16 15:53:52
On Mon, 16 Jan 2012 15:35:50 +0100 Eric Dumazet [off-list ref] wrote:
quoted hunk ↗ jump to hunk
br_fdb_cleanup() is run from timer interrupt, BH already masked. Signed-off-by: Eric Dumazet <redacted> CC: Stephen Hemminger <redacted> CC: Štefan Gula <redacted> --- net/bridge/br_fdb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index f963f6b..5ba0c84 100644 --- a/net/bridge/br_fdb.c +++ b/net/bridge/br_fdb.c@@ -146,7 +146,7 @@ void br_fdb_cleanup(unsigned long _data) unsigned long next_timer = jiffies + br->ageing_time; int i; - spin_lock_bh(&br->hash_lock); + spin_lock(&br->hash_lock); for (i = 0; i < BR_HASH_SIZE; i++) { struct net_bridge_fdb_entry *f; struct hlist_node *h, *n;@@ -162,7 +162,7 @@ void br_fdb_cleanup(unsigned long _data) next_timer = this_timer; } } - spin_unlock_bh(&br->hash_lock); + spin_unlock(&br->hash_lock); mod_timer(&br->gc_timer, round_jiffies_up(next_timer)); }
Acked-by: Stephen Hemminger <redacted>