Thread (89 messages) 89 messages, 8 authors, 2012-01-31

Re: brcm80211 breakage..

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2012-01-31 17:02:59

On Tue, Jan 31, 2012 at 4:08 AM, Henrik Rydberg [off-list ref] wrote:
probing simply fails on my machine,

[  882.064120] bcma: Failed to get SPROM: -71
[  882.064256] bcma-pci-bridge: probe of 0000:01:00.0 failed with error -2

resulting in no wireless. Since the bcma SPROM setup allegedly is
unused, simply ignoring the error with this hack
I personally hit the "No SPROM available" case, which is apparently
why it works for me.

That said, I obviously agree with your patch: if we don't fail for the
"No SPROM available" case, then we damn well shouldn't fail just
because it *is* available but we can't read it or whatever.

So Ack on the patch from me, but it should go through the network
guys. Arend, John?

                         Linus
quoted hunk ↗ jump to hunk
diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c
index febbc0a..cb69fb0 100644
--- a/drivers/bcma/main.c
+++ b/drivers/bcma/main.c
@@ -171,7 +171,6 @@ int bcma_bus_register(struct bcma_bus *bus)
               pr_err("No SPROM available\n");
       } else if (err) {
               pr_err("Failed to get SPROM: %d\n", err);
-               return -ENOENT;
       }

       /* Register found cores */
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help