Thread (15 messages) 15 messages, 4 authors, 2011-09-21

Re: [PATCH v2 3/3] net/fec: add imx6q enet support

flat view
STALE5509d SUPERSEDED

From: Shawn Guo <hidden>
Date: 2011-09-21 11:28:43
Also in: linux-arm-kernel

Revision v2 of 16 in this series.

Revisions (16)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 [diff vs current]
  4. v1 [diff vs current]
  5. v1 [diff vs current]
  6. v1 [diff vs current]
  7. v1 [diff vs current]
  8. v2
  9. v2
  10. v2 current
  11. v2
  12. v2
  13. v2
  14. v3 [diff vs current]
  15. v4 [diff vs current]
  16. v5 [diff vs current]
On Wed, Sep 21, 2011 at 08:07:42AM -0300, Fabio Estevam wrote:
On Wed, Sep 21, 2011 at 8:10 AM, Shawn Guo [off-list ref] wrote:
...
quoted
diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
index 4dbe41f..1cf6716 100644
--- a/drivers/net/ethernet/freescale/Kconfig
+++ b/drivers/net/ethernet/freescale/Kconfig
@@ -7,7 +7,7 @@ config NET_VENDOR_FREESCALE
       default y
       depends on FSL_SOC || QUICC_ENGINE || CPM1 || CPM2 || PPC_MPC512x || \
                  M523x || M527x || M5272 || M528x || M520x || M532x || \
-                  IMX_HAVE_PLATFORM_FEC || MXS_HAVE_PLATFORM_FEC || \
+                  ARCH_MXC || ARCH_MXS || \
Do you need to get rid of  IMX_HAVE_PLATFORM_FEC and MXS_HAVE_PLATFORM_FEC?
Yes, I do.  We are moving to device tree, so the Kconfig symbol
IMX_HAVE_PLATFORM_FEC makes no sense any more, as the platform device
registration will be done by DT core according whether there is a FEC
node in device tree or not.
By doing that you are selecting FEC for SoCs that don´t have this
module such as MX1/MX21/MX31.
No.  By doing that, FEC will not be selected for any SoCs by default.
You need to select it explicitly if you are building a platform with
FEC support.

-- 
Regards,
Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help