Re: [PATCH net-next] tcp: unalias tcp_skb_cb flags and ip_dsfield

Le mardi 27 septembre 2011 à 10:37 +0300, Christoph Paasch a écrit :

Hi,

I realize that before "struct tcp_skb_cb" is a comment saying that it's 44 
bytes long.

However, (as far as I can see) before Eric's change it was 42 bytes long and 
now it became 43 bytes.

Wouldn't it make sense to change the comment, so that it's consistent again 
with the real size of tcp_skb_cb ?

You are mistaken :)

There was a two bytes hole.

I took one byte for dsfield, and left one byte hole,

I added a comment to remind there is this hole

Thanks !