Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

On Aug 10, 2011, at 9:15 AM, Robin Holt wrote:

On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote:

quoted

Hi Robin,

On 08/10/2011 05:06 AM, Robin Holt wrote:

quoted

In working with the socketcan developers, we have come to the conclusion
the Documentation...fsl-flexcan.txt device tree documentation needs to
be cleaned up.  The driver does not depend upon any properties other

Your first sentence could be misleading. Please just describe what the
patch does and why, something like:

"This patch cleans up the documentation of the device-tree binding for
the Flexcan devices on Freescale's PowerPC and ARM cores. Extra
properties are not needed as the frequency of the source clock is
fixed..." and so on.

I borrowed heavily from your message. ;)

quoted

quoted

than the required properties so we are removing the file.  Additionally,
the p1010*dts* files are not following the standard for node naming in
that they have a trailing -v1.0.

quoted

Signed-off-by: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>
To: Marc Kleine-Budde <redacted>,
To: Wolfgang Grandegger <redacted>,
To: U Bhaskar-B22300 <redacted>
To: Scott Wood <redacted>
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Cc: PPC list <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Cc: Kumar Gala <redacted>
---
.../devicetree/bindings/net/can/fsl-flexcan.txt    |   61 --------------------
arch/powerpc/boot/dts/p1010rdb.dts                 |    8 ---
arch/powerpc/boot/dts/p1010si.dtsi                 |    8 +-
3 files changed, 4 insertions(+), 73 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/net/can/fsl-flexcan.txt

I don't understand how we can do this?  What binding spec covers the P1010 CAN support if you remove this?

- k