Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

On Aug 10, 2011, at 9:15 AM, Robin Holt wrote:

On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote:

quoted

Hi Robin,
=20
On 08/10/2011 05:06 AM, Robin Holt wrote:

quoted

In working with the socketcan developers, we have come to the =

conclusion

quoted

quoted

the Documentation...fsl-flexcan.txt device tree documentation needs =

to

quoted

quoted

be cleaned up.  The driver does not depend upon any properties other

=20
Your first sentence could be misleading. Please just describe what =

the

quoted

patch does and why, something like:
=20
"This patch cleans up the documentation of the device-tree binding =

for

quoted

the Flexcan devices on Freescale's PowerPC and ARM cores. Extra
properties are not needed as the frequency of the source clock is
fixed..." and so on.

=20
I borrowed heavily from your message. ;)
=20

quoted

quoted

than the required properties so we are removing the file.  =

Additionally,

quoted

quoted

the p1010*dts* files are not following the standard for node naming =

in

quoted

quoted

that they have a trailing -v1.0.

=20

quoted

Signed-off-by: Robin Holt <redacted>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
To: Wolfgang Grandegger <redacted>,
To: U Bhaskar-B22300 <redacted>
To: Scott Wood <redacted>
Cc: <redacted>,
Cc: <redacted>,
Cc: PPC list <redacted>
Cc: Kumar Gala <redacted>
---
.../devicetree/bindings/net/can/fsl-flexcan.txt    |   61 =

--------------------

quoted

quoted

arch/powerpc/boot/dts/p1010rdb.dts                 |    8 ---
arch/powerpc/boot/dts/p1010si.dtsi                 |    8 +-
3 files changed, 4 insertions(+), 73 deletions(-)
delete mode 100644 =

Documentation/devicetree/bindings/net/can/fsl-flexcan.txt

I don't understand how we can do this?  What binding spec covers the =
P1010 CAN support if you remove this?

- k