Re: [PATCH v10 3/5] [flexcan] Add of_match to platform_device definition.
From: Robin Holt <hidden>
Date: 2011-08-10 14:33:08
Also in:
linuxppc-dev
On Tue, Aug 09, 2011 at 10:06:02PM -0500, Robin Holt wrote:
quoted hunk ↗ jump to hunk
On powerpc, the OpenFirmware devices are not matched without specifying an of_match array. Introduce that array as that is used for matching on the Freescale P1010 processor. Signed-off-by: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org> To: Marc Kleine-Budde <redacted> Acked-by: Wolfgang Grandegger <redacted> To: U Bhaskar-B22300 <redacted> Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: PPC list <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org> --- drivers/net/can/flexcan.c | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-)diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c index 68cbe52..662f832 100644 --- a/drivers/net/can/flexcan.c +++ b/drivers/net/can/flexcan.c@@ -1027,8 +1027,19 @@ static int __devexit flexcan_remove(struct platform_device *pdev) return 0; } +static struct of_device_id flexcan_of_match[] = { + { + .compatible = "fsl,flexcan",
Let me make sure I have this correct. At this point, we would want it to be fsl,flexcan here. If, at some point, we find the i.MX-wonderful has diverged from the -p1010, we would, at that point in the code, use of_device_is_compatible to differentiate the two, correct? That would mean we should make no change to this patch for the fsl,flexcan-p1010, right? Robin