Re: [PATCH 7/7] bnx2x: expose HW RX VLAN stripping toggle

2011/8/31 Michal Schmidt [off-list ref]:

On Wed, 31 Aug 2011 17:37:49 +0200 Michal Schmidt wrote:

quoted

I could restore dev->features before
returning if bnx2x_reload_if_running() fails.

Or even safer - restore them always:
       ...
       u32 orig_features = dev->features;
       dev->features = features;
       ret = bnx2x_reload_if_running(dev);
       dev->features = orig_features;
       return ret;
       ...
This way we don't have to assume anything about
__netdev_update_features().

The assignment in __netdev_update_features() is just to save copying
that assignment all over the drivers' code. This won't change unless
someone wants to break^Wchange the design.

Best Regards,
Michał Mirosław