Re: [PATCH 5/7] bnx2x: do not set TPA flags and features in bnx2x_init_bp
flat view
From: Vlad Zolotarov <hidden>
Date: 2011-08-30 16:21:56
On Tuesday 30 August 2011 17:30:44 Michal Schmidt wrote:
quoted hunk ↗ jump to hunk
The .ndo_{set,fix}_features callbacks are sufficient. Signed-off-by: Michal Schmidt <redacted> --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-)diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.cb/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index 64314f7..617a072 100644--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c@@ -9752,15 +9752,6 @@ static int __devinit bnx2x_init_bp(struct bnx2x *bp) "must load devices in order!\n"); bp->multi_mode = multi_mode; - - /* Set TPA flags */ - if (disable_tpa) { - bp->flags &= ~TPA_ENABLE_FLAG; - bp->dev->features &= ~NETIF_F_LRO; - } else { - bp->flags |= TPA_ENABLE_FLAG; - bp->dev->features |= NETIF_F_LRO; - } bp->disable_tpa = disable_tpa; if (CHIP_IS_E1(bp))
NACK This patch will cause the bnx2x to initialize HW with LRO disabled on the first ifup because our code considers the TPA_ENABLE_FLAG when desiding on whether LRO is enabled or not. ethtool would still report the LRO on though! thanks, vlad