Re: [PATCH 7/7] bnx2x: expose HW RX VLAN stripping toggle

On Wednesday 31 August 2011 18:51:20 Michal Schmidt wrote:

On Wed, 31 Aug 2011 17:37:49 +0200 Michal Schmidt wrote:

quoted

I could restore dev->features before
returning if bnx2x_reload_if_running() fails.

Or even safer - restore them always:
	...
	u32 orig_features = dev->features;
	dev->features = features;
        ret = bnx2x_reload_if_running(dev);
        dev->features = orig_features;
        return ret;
	...
This way we don't have to assume anything about
__netdev_update_features().

I agree - it's the best choice if we go for a bnx2x-only solution.

thanks,
vlad

Michal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html