Re: [PATCH 1/2] netpoll: Remove unused EXPORT_SYMBOLs of netpoll_poll and netpoll_poll_dev

On Mon, Jul 04, 2011 at 12:46:29AM -0700, Joe Perches wrote:
[...]

quoted

You have removed the function declaration in include/linux/netpoll.h.

Because it's unused by anything in the tree
but netpoll.c

Hmmmm..., so sorry. I misunderstood your 'unused', which i thought
there was also no use in netpoll.c :-/

quoted

And you changed the function like 
static void netpoll_poll_dev(...)
{
	...
}
But i don't know its usage.

It's now a local function to netpoll.c

Yeah, it's true.

quoted

The 'static' before this function just says the active area of 'netpoll_poll_dev'
is in the file net/core/netpoll.c. What is the purpose? Could you please tell me?

It prods the device to perform network work.

	/* Process pending work on NIC */
	ops->ndo_poll_controller(dev);

	poll_napi(dev);

Yeah, i will read the codes.


Thanks so much
Harry Wei