Re: [PATCH 0/2] netpoll: Trivial updates

于 2011年07月01日 12:03, Joe Perches 写道:

On Fri, 2011-07-01 at 12:00 +0800, Cong Wang wrote:

quoted

于 2011年07月01日 11:55, Joe Perches 写道:

quoted

On Fri, 2011-07-01 at 11:49 +0800, Cong Wang wrote:

quoted

于 2011年07月01日 11:35, Joe Perches 写道:

quoted

quoted

BTW, you can kill the export of netpoll_send_skb_on_dev() too.

Not too sure about that.
It's used in netpoll.h by netpoll_send_skb.
It could be called from anywhere.
It's currently called/used by bonding.h.

Read what I wrote.
Look up one level at where it's used by netpoll.h.

Then move netpoll_send_skb(), export it instead of netpoll_send_skb_on_dev()...

Submit that if you choose.

Well, you are on it, I am fine to leave as it is, as you agree these
changes are all trivial. :)