Re: [PATCH 0/2] netpoll: Trivial updates

On Fri, 2011-07-01 at 11:49 +0800, Cong Wang wrote:

于 2011年07月01日 11:35, Joe Perches 写道:

quoted

quoted

BTW, you can kill the export of netpoll_send_skb_on_dev() too.

Not too sure about that.
It's used in netpoll.h by netpoll_send_skb.
It could be called from anywhere.
It's currently called/used by bonding.h.

% git grep netpoll_send_skb_on_dev .
include/linux/netpoll.h:void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb,
include/linux/netpoll.h:        netpoll_send_skb_on_dev(np, skb, np->dev);
net/core/netpoll.c:void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb,
net/core/netpoll.c:EXPORT_SYMBOL(netpoll_send_skb_on_dev);
No modules use it...

Read what I wrote.

Look up one level at where it's used by netpoll.h.