Re: [net-next v2 03/71] amd: Move AMD (Lance) chipset drivers
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2011-07-31 08:14:35
On Sun, Jul 31, 2011 at 05:26, Jeff Kirsher [off-list ref] wrote:
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/net/ethernet/amd/Kconfig@@ -0,0 +1,188 @@ +# +# AMD network device configuration +# + +config NET_VENDOR_AMD + bool "AMD devices" + depends on DIO || MACH_DECSTATION || MVME147 || ATARI || SUN3 || \ + SUN3X || SBUS || PCI || ZORRO || (ISA && ISA_DMA_API) || \ + (ARM && ARCH_EBSA110) || ISA || EISA || MCA || PCMCIA
Do you really need this big dependency? It will be true in almost all cases anyway, and the individual driver options are protected by other dependencies. Just enabling this option doesn't make the kernel bigger.
+ ---help--- + If you have a network (Ethernet) chipset belonging to this class, + say Y. + + Note that the answer to this question does not directly affect + the kernel: saying N will just case the configurator to skip all + the questions regarding AMD chipsets. If you say Y, you will be asked + for your specific chipset/driver in the following questions. + +config A2065 + tristate "A2065 support" + depends on NET_VENDOR_AMD && ZORRO
What about putting all driver sections inside "if NET_VENDOR_AMD" /
"endif", so the
individual driver configs don't need to depend on NET_VENDOR_AMD anymore?
The rest looks fine to me.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds