RE: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i

I will send the patch removing the HW information.

Yevgeny

-----Original Message-----
From: Ben Hutchings [mailto:bhutchings@solarflare.com]
Sent: Thursday, March 24, 2011 5:40 AM
To: Yevgeny Petrilin
Cc: davem@davemloft.net; netdev@vger.kernel.org; Eugenia Emantayev
Subject: RE: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool
-i

On Wed, 2011-03-23 at 15:10 +0000, Yevgeny Petrilin wrote:

quoted

quoted

This is an abuse of the ethtool_drvinfo::driver field.

Your users can use lspci -v, can't they?

I don't think there is a problem here.
We have always reported the HW model via Ethtool, we just expanded

the information

quoted

we provide.
Our users prefer to see the information in ethtool.

I can provide a patch for David if you won't.

Ben.

--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.