Re: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i

From: Yevgeny Petrilin <redacted>
Date: Wed, 23 Mar 2011 15:10:34 +0000

quoted

This is an abuse of the ethtool_drvinfo::driver field.

Your users can use lspci -v, can't they?

I don't think there is a problem here.
We have always reported the HW model via Ethtool, we just expanded the information
we provide.
Our users prefer to see the information in ethtool.

This doesn't matter, we strive for consistency across drivers rather
than have special cases like this.

Please remove the chip variant information from the ethtool driver
string, it is absolutely not appropriate.