Thread (7 messages) flat view 7 messages, 4 authors, 2011-02-22

Re: [PATCH] rt2x00: Use ops name instead of device name

From: Ivo Van Doorn <hidden>
Date: 2011-02-22 19:33:48
Also in: lkml

Hi,

On Tue, Feb 22, 2011 at 2:44 PM, Steven Rostedt [off-list ref] wrote:
On Tue, 2011-02-22 at 13:34 +0000, Ben Hutchings wrote:
quoted
quoted
19:   73474106          0   IO-APIC-fasteoi   ata_piix, uhci_hcd:usb6, 0000:05:01.0
quoted
quoted
    rt2x00dev->irq = pci_dev->irq;
-   rt2x00dev->name = pci_name(pci_dev);
+   rt2x00dev->name = ops->name;
quoted
But then how can users distinguish the IRQs for multiple devices handled
by the same driver?  (Probably unusual for WLAN devices, but still
possible.)

I assume you can't use a net device name as there may be multiple net
devices per bus device?
Honestly, I do not know this code well enough, but this patch seemed to
solve the problem at hand. Hence I sent it out to the experts hoping
they either take this patch or come up with a proper solution ;)

In any case, just posting the pci address is not a pretty answer.
I just checked the other wireless drivers, and they all seem to use
the modulename. So I guess your patch is correct. You can add my:

Acked-by: Ivo van Doorn <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help