Re: [PATCH] rt2x00: Use ops name instead of device name
From: Ben Hutchings <hidden>
Date: 2011-02-22 13:35:00
Also in:
lkml
On Tue, 2011-02-22 at 08:12 -0500, Steven Rostedt wrote:
Recently, someone complained that they see the PCI address of a device in the interrupts file instead of the device name. 19: 73474106 0 IO-APIC-fasteoi ata_piix, uhci_hcd:usb6, 0000:05:01.0
[...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/rt2x00/rt2x00pci.c b/drivers/net/wireless/rt2x00/rt2x00pci.c index ace0b66..06575dc 100644 --- a/drivers/net/wireless/rt2x00/rt2x00pci.c +++ b/drivers/net/wireless/rt2x00/rt2x00pci.c@@ -284,7 +284,7 @@ int rt2x00pci_probe(struct pci_dev *pci_dev, const struct pci_device_id *id) rt2x00dev->ops = ops; rt2x00dev->hw = hw; rt2x00dev->irq = pci_dev->irq; - rt2x00dev->name = pci_name(pci_dev); + rt2x00dev->name = ops->name; if (pci_is_pcie(pci_dev)) rt2x00_set_chip_intf(rt2x00dev, RT2X00_CHIP_INTF_PCIE);
But then how can users distinguish the IRQs for multiple devices handled by the same driver? (Probably unusual for WLAN devices, but still possible.) I assume you can't use a net device name as there may be multiple net devices per bus device? Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.