Thread (16 messages) 16 messages, 5 authors, 2011-01-14

Re: [PATCH net-next-2.6] etherdevice.h: Add is_unicast_ether_addr function

flat view

From: Joe Perches <joe@perches.com>
Date: 2011-01-13 08:43:18

On Thu, 2011-01-13 at 09:35 +0100, Tobias Klauser wrote:
On 2011-01-13 at 09:24:41 +0100, Joe Perches [off-list ref] wrote:
I added is_unicast_ether_addr to make the intention of checking for a
unicast address clearer (see [1] for context).
[1] http://article.gmane.org/gmane.linux.network/183615
quoted
I can't think of much reason that a new function for
!multicast without the !is_zero is needed.
Maybe I should just add something like the following?
#define is_unicast_ether_addr(addr) is_valid_ether_addr(addr)
Adding the #define makes a bit more sense to me.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help