Thread (16 messages) 16 messages, 5 authors, 2011-01-14

Re: [PATCH net-next-2.6] netdev: tilepro: Use is_multicast_ether_addr helper

flat view

From: David Miller <davem@davemloft.net>
Date: 2011-01-13 02:44:29

From: Chris Metcalf <redacted>
Date: Wed, 12 Jan 2011 12:49:03 -0500
On 1/12/2011 4:31 AM, Tobias Klauser wrote:
quoted
Use is_multicast_ether_addr from linux/etherdevice.h instead of a custom
macro. Also remove the broadcast address check, as it is considered a
multicast address too.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/net/tile/tilepro.c |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)
Thanks, I've taken this into the Tilera tree!
Don't, his transformation is buggy.

You can't get rid of the broadcast check, it needs to be there.
Think about it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help