RE: [RFC PATCH 1/4] net: Add support to netdev ops for changing hardware queue MAC and VLAN filters
From: Williams, Mitch A <hidden>
Date: 2009-11-24 16:14:19
From: Williams, Mitch A <hidden>
Date: 2009-11-24 16:14:19
From: Ben Hutchings [mailto:bhutchings@solarflare.com] Sent: Tuesday, November 24, 2009 6:18 AM
quoted
[snip]quoted
How does this interact with use of multiple queues within a single function? Are the specified queue numbers really interpreted as RX queue indices or as function numbers? Ben.Yeah, that is ambiguous. Would it be better if we changed the name ofthe parameter to 'vf' instead of 'queue' to make it explicit?quoted
This would give us: $ ip link set eth1 vf 1 mac <blah> The issue of which VF goes with which PF device can be deduced inuserspace via sysfs.quoted
If we want to make this apply to non SR-IOV queues, then we'll add a newparameter later.quoted
Works for you?OK, this sounds reasonable. Ben.
Thanks for looking at this stuff, Ben. I appreciate it. I'll rework the patches and send them out in a few days. -Mitch