Thread (21 messages) 21 messages, 5 authors, 2009-11-30

RE: [RFC PATCH 1/4] net: Add support to netdev ops for changing hardware queue MAC and VLAN filters

From: Ben Hutchings <hidden>
Date: 2009-11-18 23:14:28

On Wed, 2009-11-18 at 14:37 -0700, Williams, Mitch A wrote:
quoted
From: Ben Hutchings [mailto:bhutchings@solarflare.com]
Sent: Wednesday, November 18, 2009 11:53 AM
quoted
How do you remove a filter?
You remove a filter by setting it to 0 on that queue. Works for either MAC or VLAN.
quoted
What about filtering on both MAC address and VLAN (our new controller
supports that)?
Setting a MAC filter doesn't blow away the VLAN filter, or vice-versa. So just run 'ip' twice to set the filters. Our hardware does it too, and it works fine for me:

$ ip link set eth1 queue 1 mac 00:11:22:33:44:55
$ ip link set eth1 queue 1 vlan 10
Hmm, this is not what I would expect.  I'm used to filters being defined
independently of queues in a hash table or CAM.  In that case, setting
multiple filters pointing to one queue will result in the logical
disjunction of the filters.  Do I understand correctly that you have
exactly one of each type of filter per queue, with multiple filters
interpreted as a logical conjunction?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help