Re: [RFC PATCH 1/4] net: Add support to netdev ops for changing hardware queue MAC and VLAN filters
From: Ben Hutchings <hidden>
Date: 2009-11-18 19:53:03
On Tue, 2009-11-17 at 13:50 -0800, Jeff Kirsher wrote:
quoted hunk ↗ jump to hunk
From: Williams, Mitch A <redacted> Signed-off-by: Mitch Williams <redacted> Signed-off-by: Jeff Kirsher <redacted> --- include/linux/netdevice.h | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 7043f85..6a70365 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h@@ -610,6 +610,8 @@ struct netdev_queue { * this function is called when a VLAN id is unregistered. * * void (*ndo_poll_controller)(struct net_device *dev); + * int (*ndo_set_queue_mac)(struct net_device *dev, int queue, u8* mac); + * int (*ndo_set_queue_vlan)(struct net_device *dev, int queue, u16 vlan); */ #define HAVE_NET_DEVICE_OPS struct net_device_ops {@@ -659,6 +661,10 @@ struct net_device_ops { #define HAVE_NETDEV_POLL void (*ndo_poll_controller)(struct net_device *dev); #endif + int (*ndo_set_queue_mac)(struct net_device *dev, + int queue, u8 *mac); + int (*ndo_set_queue_vlan)(struct net_device *dev, + int queue, u16 vlan);
[...] How do you remove a filter? What about filtering on both MAC address and VLAN (our new controller supports that)? It seems like this could be defined as an extension to the existing ethtool RX flow filter API. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.