Thread (17 messages) 17 messages, 5 authors, 2009-10-29

Re: [PATCH 6/9] ser_gigaset: checkpatch cleanup

From: Tilman Schmidt <hidden>
Date: 2009-10-25 23:37:08
Also in: lkml

Alan Cox schrieb:
quoted
-		if (!(bcs->tx_skb = skb_dequeue(&bcs->squeue)))
+		nextskb = skb_dequeue(&bcs->squeue);
+		if (!nextskb)
 			/* no skb either, nothing to do */
 			return;
+		bcs->tx_skb = nextskb;
This does not do the same thing as before

Previously the NULL case assigned to bcs->tx_skb, now it does not.
bcs->tx_skb is guaranteed to be NULL already at this point because
of the enclosing "if (!bcs->tx_skb)".

Thanks,
Tilman

-- 
Tilman Schmidt                    E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help