On Sun, 25 Oct 2009 20:30:27 +0100 (CET)
Tilman Schmidt [off-list ref] wrote:

Duly uglified as demanded by checkpatch.pl.

Impact: cosmeti

Umm ??

-		if (!(bcs->tx_skb = skb_dequeue(&bcs->squeue)))
+		nextskb = skb_dequeue(&bcs->squeue);
+		if (!nextskb)
 			/* no skb either, nothing to do */
 			return;
+		bcs->tx_skb = nextskb;

This does not do the same thing as before

Previously the NULL case assigned to bcs->tx_skb, now it does not.