[PATCH 2/9] gigaset: fix format string typo in CAPI dial command
From: Tilman Schmidt <hidden>
Date: 2009-10-25 19:29:56
Also in:
lkml
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Tilman Schmidt <hidden>
Date: 2009-10-25 19:29:56
Also in:
lkml
Subsystem:
the rest · Maintainer:
Linus Torvalds
A missing dot lead to garbage characters being included in the dial command generated from a CAPI CONNECT_REQ message, which interestingly enough worked anyway, illustrating the resilience of the device. Impact: bugfix Signed-off-by: Tilman Schmidt <redacted> --- drivers/isdn/gigaset/capi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c
index ac0a2da..d1afac2 100644
--- a/drivers/isdn/gigaset/capi.c
+++ b/drivers/isdn/gigaset/capi.c@@ -1254,7 +1254,7 @@ static void do_connect_req(struct gigaset_capi_ctr *iif, commands[AT_DIAL] = kmalloc(l+3, GFP_KERNEL); if (!commands[AT_DIAL]) goto oom; - snprintf(commands[AT_DIAL], l+3, "D%*s\r", l, pp); + snprintf(commands[AT_DIAL], l+3, "D%.*s\r", l, pp); /* encode parameter: Calling party number */ pp = cmsg->CallingPartyNumber;
--
1.6.2.1.214.ge986c