Thread (10 messages) 10 messages, 3 authors, 2009-07-28

Re: [PATCH V2] CAN: Add Flexcan CAN controller driver

From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: 2009-07-28 14:12:12

Oliver Hartkopp wrote:
Sascha Hauer wrote:
quoted
quoted
quoted
+
+	if (frame->can_id & CAN_RTR_FLAG)
+		dlc |= MB_CNT_RTR;
+
+	writel(dlc, &regs->cantxfg[TX_BUF_ID].can_dlc);
+	writel(can_id, &regs->cantxfg[TX_BUF_ID].can_id);
Are you sure, that this is correct?

Indeed i wonder, if it would make sense to skip the entire struct flexcan_mb
approach and fiddle byte-by-byte inside the registers ...

Regards,
Oliver
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help