Thread (95 messages) 95 messages, 9 authors, 2008-12-04

Re: [PATCH 10/39] wimax: Generic messaging interface between user space and driver/device

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2008-11-27 09:56:15

On Wed, 2008-11-26 at 15:07 -0800, Inaky Perez-Gonzalez wrote:
This implements a direct communication channel between user space and
the driver/device, by which free form messages can be sent back and
forth.

This is intended for device-specific features, vendor quirks, etc.

Currently is the only communication mechanism used because there is no
standard kernel API defined for WiMAX operation. Not enough devices
are in the market to decide what is a good user-kernel API/abstraction
layer.
Obviously I don't like this, reminds me too much of iwpriv. What kind of
messages are you passing now? What would be wrong with defining those
things you need now as actual commands, and then later
extending/modifying the command set when new hardware shows up?

That's what we're doing in cfg80211, simply adding commands as we go
along and not everybody has to support all commands, ultimately. You can
always even query the supported command set via the genl controller.
+struct genl_ops wimax_gnl_msg_from_user = {
+	.cmd = WIMAX_GNL_OP_MSG_FROM_USER,
+	.flags = 0,
same thing with permissions here

johannes

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help