On Wed, 2008-11-26 at 15:07 -0800, Inaky Perez-Gonzalez wrote:

+static inline __must_check
+int wimax_dev_is_ready(struct wimax_dev *wimax_dev)
+{
+	if (wimax_dev->state == __WIMAX_ST_NULL)
+		return -EINVAL;	/* Device is not even registered! */
+	if (wimax_dev->state == WIMAX_ST_DOWN)
+		return -ENOMEDIUM;

ENOLINK seems more appropriate?

+/*
+ * The concept of a pipe -- we encapsulate it because we want to
+ * detach the usage of it from the implementation, and thus it serves
+ * just as a handle.

Might help to explain just what the concept is :)

johannes