Em Fri, Mar 28, 2008 at 06:22:58PM +0300, Denis V. Lunev escreveu:

On Fri, 2008-03-28 at 11:44 -0300, Arnaldo Carvalho de Melo wrote:

quoted

Em Fri, Mar 28, 2008 at 12:08:50PM +0300, Denis V. Lunev escreveu:

quoted

This seems a purism as module can't be unloaded, but though if cleanup method
is present it should be correct and clean all staff created.

Its the right thing to do :-) But perhaps we could have a
inet_csk_ctl_sock_destroy() as we have inet_csk_ctl_sock_create?

And since this is not csk at all, could you please rename it to
inet_ctl_sock_{create,destroy}()? I Agree with Vlad and Pavel that this
would make it more clear, as SCTP is not (yet) a inet_connection_sock.

Basically, after these sockets will be moved into namespace we'll use
sk_release_kernel for them.

Can I send a rename as a follow up on Monday :) ?

Logically the rename should be done first, then its use, but its up to
Dave/you.

- Arnaldo