Thread (3 messages) 3 messages, 3 authors, 2008-03-28

Re: [PATCH 3/11 net-2.6.26] [DCCP]: dccp_v(4|6)_ctl_socket is leaked.

From: Denis V. Lunev <hidden>
Date: 2008-03-28 15:22:53

On Fri, 2008-03-28 at 11:44 -0300, Arnaldo Carvalho de Melo wrote:
Em Fri, Mar 28, 2008 at 12:08:50PM +0300, Denis V. Lunev escreveu:
quoted
This seems a purism as module can't be unloaded, but though if cleanup method
is present it should be correct and clean all staff created.
Its the right thing to do :-) But perhaps we could have a
inet_csk_ctl_sock_destroy() as we have inet_csk_ctl_sock_create?

And since this is not csk at all, could you please rename it to
inet_ctl_sock_{create,destroy}()? I Agree with Vlad and Pavel that this
would make it more clear, as SCTP is not (yet) a inet_connection_sock.
Basically, after these sockets will be moved into namespace we'll use
sk_release_kernel for them.

Can I send a rename as a follow up on Monday :) ?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help