Re: [PATCH 3/11 net-2.6.26] [DCCP]: dccp_v(4|6)_ctl_socket is leaked.
From: Arnaldo Carvalho de Melo <hidden>
Date: 2008-03-28 14:44:46
From: Arnaldo Carvalho de Melo <hidden>
Date: 2008-03-28 14:44:46
Em Fri, Mar 28, 2008 at 12:08:50PM +0300, Denis V. Lunev escreveu:
This seems a purism as module can't be unloaded, but though if cleanup method is present it should be correct and clean all staff created.
Its the right thing to do :-) But perhaps we could have a
inet_csk_ctl_sock_destroy() as we have inet_csk_ctl_sock_create?
And since this is not csk at all, could you please rename it to
inet_ctl_sock_{create,destroy}()? I Agree with Vlad and Pavel that this
would make it more clear, as SCTP is not (yet) a inet_connection_sock.
- Arnaldo